Codecov Report

Merging #8822 (17cc899) into main (f815e9f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8822   +/-   ##
=======================================
  Coverage   95.89%   95.90%           
=======================================
  Files         173      173           
  Lines       18511    18515    +4     
=======================================
+ Hits        17752    17756    +4     
  Misses        759      759           

Working on patch for the stdlib primer issue (regression in pylint-dev/astroid#2231) 👀

EDIT: see pylint-dev/astroid#2235

Blocked by pylint-dev/astroid#2237.

Primer result isn't helpful (same result on #8824). I ran it locally. No change. Something's up on CI. I reopened #8790.

I'll remove the commit that pins to my fix branch. Then I suggest merging this in the next few days. main will fail until we get astroid 3.0.0a7 with pylint-dev/astroid#2235, but then the question is whether we do a release for a single hotfix only OR do we just roll in the try node from pylint-dev/astroid#1867 also and publish 3.0.0a7 with that. Slight preference for the latter. The primer being down for a couple days is fine. Then we can work on compatibility with the new try node in a separate PR from this one (#7767).

@Pierre-Sassoulas your thoughts? 🙏

Main would fail until we release astroid 3.0.0a7 ?

Yeah, if we merge this then main will fail until we upgrade to the next astroid alpha. If that's not okay, then we can do an astroid alpha just for the regression fix. I just didn't want to create extra work.

Or we can hold this PR and merge it into #7767, but I wanted to avoid that because they're two large PRs.

Let's release a new astroid, this is less work than telling all contributors that the primer also fail on main (it's not that much work, two tbump and a tag). Should I release asap ?

Sure! Thanks.

@Pierre-Sassoulas the pin didn't work. The error message from pip is difficult to make sense of. I'll go see if there's an open issue against pip. In any case, should I just rebase #7767 on top of these first three commits and just do a single PR anyway?

Let's go with a single PR it seems to be the simpler option ? If not do whatever you find more conveniant :D I'm on mobile I can't release astroid 3.0.0a7 right now, I expect to be able to before tommorow

Never mind! One file said "astroid" and the other said "astroid.git", and standardizing them fixed the pip resolver.

This should be good to merge.

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 17cc899